Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secure-onboarding) Update the cloudauth pb.go files #432

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

ravinadhruve10
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 commented Oct 20, 2023

Fix summary:

Update the cloudauth go files to support newly added providerAlias field.

Testing done:

Validated with the acceptance tests on staging.

Fix summary:
--------------
Update the cloudauth go files to support newly added providerAlias field.
@ravinadhruve10 ravinadhruve10 marked this pull request as ready for review October 20, 2023 19:01
@haresh-suresh
Copy link
Contributor

Will this require a version update in our onboarding apis ?

Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we also going to enable DiscardUnknown?

@ravinadhruve10
Copy link
Contributor Author

Will this require a version update in our onboarding apis ?

yes

@ravinadhruve10
Copy link
Contributor Author

are we also going to enable DiscardUnknown?

Done.

@ravinadhruve10 ravinadhruve10 merged commit e1eefe8 into master Oct 20, 2023
23 checks passed
@ravinadhruve10 ravinadhruve10 deleted the update/apifield-secure-onboarding branch October 20, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants