Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudauth): organizational units #437

Merged
merged 4 commits into from
Oct 31, 2023
Merged

feat(cloudauth): organizational units #437

merged 4 commits into from
Oct 31, 2023

Conversation

cgeers
Copy link
Contributor

@cgeers cgeers commented Oct 26, 2023

  • add organizational_unit_ids to the secure organization resource

@cgeers cgeers force-pushed the feat/cloudauth/organization_units branch from f5bb9db to 0a5f557 Compare October 26, 2023 21:39
ravinadhruve10
ravinadhruve10 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change lgtm. Good to have another set of eyes review it.
Were we able to test it that it works and has no regressions?

@ravinadhruve10
Copy link
Contributor

Overall the change lgtm. Good to have another set of eyes review it. Were we able to test it that it works and has no regressions?

Missed out on this. we will need a documentation change here with this new optional schema field.

ravinadhruve10
ravinadhruve10 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the documentation change as well as part of this PR?

@cgeers cgeers force-pushed the feat/cloudauth/organization_units branch from feaa3b2 to 07d67e5 Compare October 31, 2023 16:32
@cgeers cgeers force-pushed the feat/cloudauth/organization_units branch from 07d67e5 to 74784b9 Compare October 31, 2023 18:00
@cgeers cgeers merged commit bf2eb19 into master Oct 31, 2023
23 checks passed
@cgeers cgeers deleted the feat/cloudauth/organization_units branch October 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgeers @ravinadhruve10