fix(secure-onboarding) Fix component and key state #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix summary: ------------- Correctly manage the components state and key state 1. Updated the API call with query param. 2. Handling resource data to api objects and api objects to resource data conversions. 3. Handling decoding/encoding of keys and json conversions with proper indentation. 4. Refactored the structure to maintain order in the component schema list field as well as key fields. 5. Refactored some of the naming of methods and vars. Testing done: -------------- Validated with acceptance tests on staging and E2E tests. Left with one issue to fix. Marking it draft.
cgeers
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary:
Correctly manage the components state and key state
Testing done:
Validated with acceptance tests on staging and E2E tests.