Add secure-onboarding organization acc test #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change summary: ---------------- Terraform acceptance tests use real Terraform configurations to exercise the code in real plan, apply, refresh, and destroy life cycles. TF acceptance tests for secure org onboarding need an actual existing gcp project along with an actual service_principal_key to scrape all folders and projects under the org. Without it POST /organizations API fail with 500 error and hence we could not add org acceptance tests working with the sysdig backend APIs. To handle this, adding the org acceptance tests with skip on this particular error check. With this, we can get some decent test coverage for the HCL and the APIs for org.
mdkulkarni15
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
As per TF documentation - Terraform acceptance tests use real Terraform configurations to exercise the code in real plan, apply, refresh, and destroy life cycles.
TF acceptance tests for secure org onboarding need an actual existing gcp project along with an actual service_principal_key to scrape all folders and projects under the org. Without it POST /organizations API fail with 500 error and hence we could not add org acceptance tests working with the sysdig backend APIs.
To handle this, adding the org acceptance tests with skip on this particular error check. With this, we can get some decent test coverage as a start :-