Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add meta titles & descriptions #1498

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

buhodev
Copy link
Contributor

@buhodev buhodev commented Oct 23, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@syself-bot syself-bot bot added the size/S Denotes a PR that changes 20-50 lines, ignoring generated files. label Oct 23, 2024
@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. and removed size/S Denotes a PR that changes 20-50 lines, ignoring generated files. labels Oct 23, 2024
@buhodev buhodev changed the title 🌱 add descriptions 🌱 add meta titles & descriptions Oct 23, 2024
Copy link
Contributor

@lucasrattz lucasrattz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pertinent for all titles: "Cluster API for Hetzner" is not an existing term. We should either use the full name of the project "Cluster API Provider Hetzner", or the abbreviation "CAPH". Maybe just "Cluster API" if it's talking about it's resources or something.

@syself-bot syself-bot bot added size/L Denotes a PR that changes 200-800 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Nov 1, 2024
@buhodev buhodev marked this pull request as ready for review November 1, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 200-800 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants