Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication rework - draft2 - DONOTMERGE #4220

Draft
wants to merge 1 commit into
base: v2.x
Choose a base branch
from

Conversation

renecannao
Copy link
Contributor

Support for caching_sha2_password .
New variable mysql-default_authentication_plugin .
Deprecate variable admin-hash_passwords #4218 .

Although fully functional, it is still a work in progress.

It also deprecate PR #4136

lib/sha256crypt.cpp Dismissed Show dismissed Hide dismissed
@renecannao
Copy link
Contributor Author

retest this please

1 similar comment
@renecannao
Copy link
Contributor Author

retest this please

@yakirgb
Copy link
Contributor

yakirgb commented Feb 15, 2024

@renecannao Is it will be global variable or per user ?
Because if doing migration of users from mysql_native_password to caching_sha2_password , we will do it user by user and not for all users together .

@renecannao
Copy link
Contributor Author

@yakirgb : the new variable MUST be global , not just because it is the "default" plugin, but because in MySQL protocol authentication, the server (proxysql in this case) is the first that specifies the default authentication method, even before the client sends its username.
That said, depending from how passwords are stored in mysql_users.password , user can use either mysql_native_password or caching_sha2_password . And proxysql can use the same or a different authentication method when connecting to the backend.

@yakirgb
Copy link
Contributor

yakirgb commented Feb 15, 2024

Thank you for the explain.

@mirostauder
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants