Handle misalignment properly in jump-link instruction #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jul 22, 2023
jserv
changed the title
jserv
requested changes
Jul 22, 2023
|
In addition, use plain text in git commit messages rather than markdown. |
As per the specifications, if a branch or jump instruction is found to have an instruction-address-misaligned exception, it indicates that the `rd` would not be updated. To maintain simplicity, the `do_jump` function will continue to handle branch instructions, which modifications will be made exclusively to the `op_jump_link` function. Reference: https://riscv.org/technical/specifications/
|
Thank @chiangkd for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From spec, an instruction-address-misaligned exception is reported on the branch or jump instruction, implying rd would not be updated.
For simplicity, I keep
do_jumpfunction to handle branch instruction, and modify onlyop_jump_linkfunction.Reference: https://riscv.org/technical/specifications/ (section 2.2)