Fix snapshot test #119
Merged
Fix snapshot test #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 19, 2024
jserv
reviewed
Mar 19, 2024
The current snapshot is a JSON object which dumped by the `dot` utility. The keys of object or the elements of arrays might not be sorted by the `jq` and could make the `diff` command failed. The incoming changes make sure the keys and the elements to be sorted before saving/checking the snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsorted slots in the snapshots are considered to be the error sometimes by the
diffcommand. Sort the slots before saving/checking the snapshots.Related PR: