Fix potential out-of-bounds access in strncmp() #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current strncmp() implementation may continue comparing strings
when they are identical and shorter than 'len', leading to potential
out-of-bounds memory access. For example, strncmp("abc", "abc", 5)
could access memory beyond the end of the strings.
Add a check to return 0 if the end of either string is reached before
'len', preventing unintended memory access.
visitorckw
force-pushed
the
fix-strncmp
branch
from
a809eba
to
529d827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current strncmp() implementation may continue comparing strings when they are identical and shorter than 'len', leading to potential out-of-bounds memory access. For example, strncmp("abc", "abc", 5) could access memory beyond the end of the strings.
Add a check to return 0 if the end of either string is reached before 'len', preventing unintended memory access.