Optimize trie operations by replacing tail recursion with iteration #149
Conversation
Replace tail-recursive calls in insert_trie() and find_trie() with an iterative loop to reduce function call overhead and avoid potential stack overflow issues. The logic remains functionally equivalent, improving performance and stability.
| * way to handle this is to dynamically allocate a new element. | ||
| */ | ||
| trie->next[fc] = func_tries_idx++; | ||
| for (int i = 0; i < 128; i++) |
There was a problem hiding this comment.
I am not sure if 128 is a proper range for such purpose. Can you determine?
There was a problem hiding this comment.
In fact, the names of C functions can only contain a total of 63 characters: underscores, digits 0-9, and letters a-z and A-Z. Therefore, using 128 next entries for each node is indeed a waste of memory.
There was a problem hiding this comment.
However, I think we might be able to address this issue in a later patch since it differs from the objective of this patch?
There was a problem hiding this comment.
However, I think we might be able to address this issue in a later patch since it differs from the objective of this patch?
up to you. We are experiencing performance issues during bootstrapping, and it would be beneficial to identify and resolve these to speed up the compilation process.
There was a problem hiding this comment.
BTW, I think using a radix tree here could further improve memory savings. I can give it a try later.
|
Thank @visitorckw for contributing! Let's move forward. |
Replace tail-recursive calls in insert_trie() and find_trie() with an iterative loop to reduce function call overhead and avoid potential stack overflow issues. The logic remains functionally equivalent, improving performance and stability.