Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Containerfile for development #418

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add Containerfile for development #418

merged 1 commit into from
Dec 12, 2024

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Oct 16, 2023

Add a command to create a Debian-based container with the SDCC and Rust toolchains installed in order to minimize the workspace setup time and ensure build environments are the same.

make -C containers
podman run -it --rm \
    -v $PWD:/workspace:Z \
    system76/ec:latest \
    make BOARD=system76/oryp8

A locally built image is 1.07 GiB.

@crawfxrd crawfxrd force-pushed the containers branch 2 times, most recently from 41beb57 to 515cc4f Compare March 1, 2024 19:54
@crawfxrd crawfxrd changed the title Add Containerfiles for SDCC Add Containerfile for development Jul 6, 2024
@crawfxrd crawfxrd marked this pull request as ready for review July 6, 2024 01:26
@crawfxrd crawfxrd requested review from a team July 6, 2024 01:26
@XV-02
Copy link

XV-02 commented Jul 18, 2024

Should we update ec/scripts/deps.sh to include the podman dependency for containerized builds?

@crawfxrd
Copy link
Member Author

There is no integration for using the container yet, so podman is not a dependency.

Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, EC is building correctly for every system I've tried using the containerized build process. Seems to be working if Engineering wants to move forward with it.

Add a command to create a Debian-based container with the SDCC and Rust
toolchains installed in order to minimize the setup time of a
container-based workflow, such as CI.

    make -C containers
    podman run -it --rm \
        -v $PWD:/workspace:Z \
        system76/ec:latest \
        make BOARD=system76/oryp8

Signed-off-by: Tim Crawford <[email protected]>
@jackpot51 jackpot51 requested a review from a team December 12, 2024 04:07
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested, still working

@jackpot51 jackpot51 merged commit 683806f into master Dec 12, 2024
48 checks passed
@jackpot51 jackpot51 deleted the containers branch December 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants