-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Containerfile for development #418
Conversation
41beb57
to
515cc4f
Compare
Should we update ec/scripts/deps.sh to include the |
There is no integration for using the container yet, so podman is not a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, EC is building correctly for every system I've tried using the containerized build process. Seems to be working if Engineering wants to move forward with it.
Add a command to create a Debian-based container with the SDCC and Rust toolchains installed in order to minimize the setup time of a container-based workflow, such as CI. make -C containers podman run -it --rm \ -v $PWD:/workspace:Z \ system76/ec:latest \ make BOARD=system76/oryp8 Signed-off-by: Tim Crawford <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested, still working
Add a command to create a Debian-based container with the SDCC and Rust toolchains installed in order to minimize the workspace setup time and ensure build environments are the same.
A locally built image is 1.07 GiB.