crate naming

systemaccounting · Jan 9, 2024 · 87a16a6 · 87a16a6
1 parent bdf2c2e
commit 87a16a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/dev-crates.yaml b/.github/workflows/dev-crates.yaml
@@ -48,12 +48,12 @@ jobs:
             echo 'coverage dropped below ${{ env.MIN_CODE_COV }}: ${{ env.CURR_CODE_COV }}%'
             exit 1
           fi
-      - name: crates/httpcrate coverage report
+      - name: crates/httpclient coverage report
         run: |
-          make rust-coverage RUST_PKG=httpcrate
-          echo "MIN_CODE_COV=$(yq .crates.httpcrate.min_code_cov project.yaml)" >> $GITHUB_ENV
-          echo "CURR_CODE_COV=$(make rust-coverage-percent RUST_PKG=httpcrate)" >> $GITHUB_ENV
-      - name: fail crates/httpcrate coverage under ${{ env.MIN_CODE_COV }}%
+          make rust-coverage RUST_PKG=httpclient
+          echo "MIN_CODE_COV=$(yq .crates.httpclient.min_code_cov project.yaml)" >> $GITHUB_ENV
+          echo "CURR_CODE_COV=$(make rust-coverage-percent RUST_PKG=httpclient)" >> $GITHUB_ENV
+      - name: fail crates/httpclient coverage under ${{ env.MIN_CODE_COV }}%
         run: |
           if [[ ${{ env.CURR_CODE_COV }} -lt ${{ env.MIN_CODE_COV }} ]]; then
             echo 'coverage dropped below ${{ env.MIN_CODE_COV }}: ${{ env.CURR_CODE_COV }}%'

diff --git a/crates/httpclient/src/lib.rs b/crates/httpclient/src/lib.rs
@@ -28,6 +28,8 @@ impl HttpClient {
             )
             .body(body)
             .unwrap();
+
+        // sign request if running in lambda
         if env::var("AWS_LAMBDA_FUNCTION_NAME").ok().is_some() {
             HttpClient::sign(&mut http_request).await;
         }