Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic push to Dockerhub #365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Contributor

This automatically builds a docker image and pushes it to my personal Dockerhub account on each push to systemed/master.

If you don't want to use lehrenfried/tilemaker, I'm happy to help setting up the account. Let me know what you would like to do.

Note: This requires a Github Action secret called DOCKERHUB_TOKEN. Once we've decided on a course of action, I will get the token to you.

/cc @guillaumerose

@leonardehrenfried leonardehrenfried marked this pull request as draft January 19, 2022 18:42
@leonardehrenfried leonardehrenfried marked this pull request as ready for review January 21, 2022 15:16
@vinayakkulkarni
Copy link

btw, we can use ghcr.io instead of Dockerhub.

@leonardehrenfried
Copy link
Contributor Author

Hi @systemed, is there any interest in providing a container image on every push to master?

@systemed
Copy link
Owner

systemed commented Aug 1, 2022

Sounds fine. I have close to zero knowledge of Docker so if people tell me that something is good or not then I'm happy to go with that!

@leonardehrenfried
Copy link
Contributor Author

leonardehrenfried commented Aug 1, 2022

It does require that you add a secret variable to your Github Actions configuration. Are you ok with this?

And then there is the question of which account this should be published to. I'm happy to use my personal account to ease the maintenance burden for you but I'm also happy to set up an account for systemed or tilemaker.

@leonardehrenfried
Copy link
Contributor Author

btw, we can use ghcr.io instead of Dockerhub.

That is an option but it's quite restricted in terms of bandwidth and storage so I don't really recommend it.

@leonardehrenfried
Copy link
Contributor Author

Closed in favour of #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants