Fix a bug

systemxlabs · Apr 19, 2024 · a329d06 · a329d06
1 parent c1e7ecf
commit a329d06
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ballista/scheduler/src/cluster/kv.rs b/ballista/scheduler/src/cluster/kv.rs
@@ -327,6 +327,9 @@ impl<S: KeyValueStore, T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan>
             metadata.value().clone()
         } else {
             let value = self.store.get(Keyspace::Executors, executor_id).await?;
+            if value.is_empty() {
+                return Err(BallistaError::Internal(format!("Executor {} not registered", executor_id)))
+            }
             let decoded = decode_into::<protobuf::ExecutorMetadata, ExecutorMetadata>(&value)?;
             self.executors
                 .insert(executor_id.to_string(), decoded.clone());

diff --git a/ballista/scheduler/src/scheduler_server/grpc.rs b/ballista/scheduler/src/scheduler_server/grpc.rs
@@ -180,9 +180,7 @@ mod test {
 
     use super::{SchedulerGrpc, SchedulerServer};
 
-    // TODO fixme
     #[tokio::test]
-    #[ignore]
     async fn test_register_executor_in_heartbeat_service() -> Result<(), BallistaError> {
         let cluster = test_cluster_context();