cleanup ci tasks

.github/workflows/rust.yml

@@ -283,7 +283,7 @@ jobs:
           rustup default stable
           rustup component add rustfmt
       - name: Run
-        run: ci/scripts/rust_fmt.sh
+        run: cargo fmt --all -- --check
         env:
           CARGO_HOME: "/github/home/.cargo"
           CARGO_TARGET_DIR: "/github/home/target"
@@ -326,103 +326,7 @@ jobs:
         run: |
           rustup component add clippy
       - name: Run clippy
-        run: ci/scripts/rust_clippy.sh
+        run: cargo clippy --all-targets --workspace -- -D warnings
         env:
           CARGO_HOME: "/github/home/.cargo"
-          CARGO_TARGET_DIR: "/github/home/target"
-
-  cargo-toml-formatting-checks:
-    name: Check Cargo.toml formatting
-    needs: [linux-build-lib]
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        arch: [amd64]
-        rust: [stable]
-    container:
-      image: ${{ matrix.arch }}/rust
-      env:
-        # Disable full debug symbol generation to speed up CI build and keep memory down
-        # "1" means line tables only, which is useful for panic tracebacks.
-        RUSTFLAGS: "-C debuginfo=1"
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          submodules: true
-      - name: Cache Cargo
-        uses: actions/cache@v3
-        with:
-          path: /github/home/.cargo
-          # this key equals the ones on `linux-build-lib` for re-use
-          key: cargo-cache-
-      - name: Cache Rust dependencies
-        uses: actions/cache@v3
-        with:
-          path: /github/home/target
-          # this key equals the ones on `linux-build-lib` for re-use
-          key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}
-      - name: Setup Rust toolchain
-        uses: ./.github/actions/setup-builder
-        with:
-          rust-version: ${{ matrix.rust }}
-      - name: Install cargo-tomlfmt
-        run: |
-          which cargo-tomlfmt || cargo install cargo-tomlfmt
-        env:
-          CARGO_HOME: "/github/home/.cargo"
-          CARGO_TARGET_DIR: "/github/home/target"
-      - name: Check Cargo.toml formatting
-        run: |
-          # if you encounter error, try rerun the command below, finally run 'git diff' to
-          # check which Cargo.toml introduces formatting violation
-          #
-          # ignore ./Cargo.toml because putting workspaces in multi-line lists make it easy to read
-          ci/scripts/rust_toml_fmt.sh
-          if test -f "./Cargo.toml.bak"; then
-              echo "cargo tomlfmt found format violations"
-              exit 1
-          fi
-        env:
-          CARGO_HOME: "/github/home/.cargo"
-          CARGO_TARGET_DIR: "/github/home/target"
-
-# Coverage job was failing. https://github.com/apache/arrow-datafusion/issues/590 tracks re-instating it
-
-# coverage:
-#   name: Coverage
-#   runs-on: ubuntu-latest
-#   strategy:
-#     matrix:
-#       arch: [amd64]
-#       rust: [stable]
-#   steps:
-#     - uses: actions/checkout@v3
-#       with:
-#         submodules: true
-#     - name: Cache Cargo
-#       uses: actions/cache@v3
-#       with:
-#         path: /home/runner/.cargo
-#         # this key is not equal because the user is different than on a container (runner vs github)
-#         key: cargo-coverage-cache-
-#     - name: Cache Rust dependencies
-#       uses: actions/cache@v3
-#       with:
-#         path: /home/runner/target
-#         # this key is not equal because coverage uses different compilation flags.
-#         key: ${{ runner.os }}-${{ matrix.arch }}-target-coverage-cache-${{ matrix.rust }}-
-#     - name: Run coverage
-#       run: |
-#         export ARROW_TEST_DATA=$(pwd)/testing/data
-#         export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
-
-#         # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
-#         # see https://github.com/xd009642/tarpaulin/issues/618
-#         cargo install --version 0.16.0 cargo-tarpaulin
-#         cargo tarpaulin --out Xml
-#       env:
-#         CARGO_HOME: "/home/runner/.cargo"
-#         CARGO_TARGET_DIR: "/home/runner/target"
-#     - name: Report coverage
-#       continue-on-error: true
-#       run: bash <(curl -s https://codecov.io/bash)
+          CARGO_TARGET_DIR: "/github/home/target"