Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect htmlized and failing to load on WordPress #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwire
Copy link

I only tested this on WordPress but the multiple document download was failing.

The queue was running but then the redirect went to the homepage instead of the download page.

Generated URL:
https://[example.org]/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcivioffice%2Fdownload&id=replacedwithhiddenid&instant_download=0&return_url=replacedwithhiddenencodedreturnurl

Required URL:
https://[example.org]/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fcivioffice%2Fdownload&id=replacedwithhiddenid&instant_download=0&return_url=replacedwithhiddenencodedreturnurl

@vurt2
Copy link

vurt2 commented Aug 6, 2024

I just ran into the same problem with wordpress. This fixes it.

Before I encountered this pr I also patched the file in my systems.
There is another occurrence of the RM_Utils_System::url() function in runViaWebUrl() in the same file which should also be fixed in my opinion. There is an "&" in the query parameter which should not be htmlizied.

best Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants