Remove unnecessary hack copied from core form controllers #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
enhancement
|
Seems fine to me. Are the test failures unrelated? |
colemanw
approved these changes
Jun 11, 2024
The tests seem broken currently ( |
jensschuppe
added
status:reviewed and tested
jensschuppe
added a commit
that referenced
this pull request
Jun 11, 2024
jensschuppe
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got copied from places like https://github.com/civicrm/civicrm-core/blob/7a9c0823b43c02bcc1e3d1a2eca19e80302274d0/CRM/Event/Form/ManageEvent.php#L366 but I can't see why this is necessary, as that's a Page controller, not a Form one …
@colemanw any objections against removing this?
PS. This should also go into the
1.0.xbranch when merging.