Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in GitHub action #90

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Aug 1, 2024

Extension template is installed. No github action for phpcs and phpstan,
yet, because of too much errors. They need to be fixed first. Maybe the
phpstan level could be (initially) reduced.

There are some failing tests: https://github.com/systopia/de.systopia.remoteevent/actions/runs/10200192871/job/28219050111?pr=90#step:6:3170

convertWarningsToExceptions is currently disabled in phpunit.xml.dist because of undefined array key access: https://github.com/systopia/de.systopia.remoteevent/actions/runs/10200192871/job/28219050111?pr=90#step:6:14

Dominic Tubach added 2 commits August 1, 2024 14:51
Extension template is installed. No github action for phpcs and phpstan,
yet, because of too much errors. They need to be fixed first. Maybe the
phpstan level could be (initially) reduced.
@dontub dontub force-pushed the run-tests-in-github-action branch from e978f62 to d6240d9 Compare August 1, 2024 13:23
@dontub dontub added the status:needs review Code needs review and testing label Aug 1, 2024
@jensschuppe jensschuppe removed their request for review August 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs review Code needs review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant