Improve the handling of organisations #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
the
status:needs work
|
Alright, I understand that it would make sense to make some things configurable and that it would then be an enhancement. (see #83 (comment)) In the meantime, could we at least merge commit 6869757? This is a bug that is currently preventing contacts from receiving a donation receipt. |
|
Moved this part
out into #94. So this PR leaves us with the option to assign the organisation to the membership, rather than the individual, which should be made configurable and have either the current behavior as default or an upgrader for restoring the current behavior to existing profiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
user_companyfield is submitted, an organisation and an individual are currently created and linked. The downstream logic will then only refer to the individual and ignore the organisation. Instead, I would like to relate everything related to the contribution-contact relationship to the organisation rather than the individual.This PR:
donation_receiptgroup membership for the organisation if one is provided.I would argue that in this case we should refrain from making the change configurable, as the current behaviour is illogical (certainly in the case of the donation_receipt group).