caption_frame_decode: rework API #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes szatmary#59 * pop_on mode requires incrementing the frame timestamp until end_of_caption is encountered. * caption_frame_decode now always updates the timestamp of the frame when the timestamp parameter != -1. This requires that callers only pass a valid timestamp when a new one is encountered, for example with SCC the timestamp at the start of the cue, then -1 until the next new timestamp. * A new enum member is added for the return value, LIBCAPTION_CLEAR. It allows the caller to determine that closed captions should not be displayed anymore, in order to finish the previous cue earlier than the start of the next cue.
|
ping @szatmary :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
pop_on mode requires incrementing the frame timestamp until
end_of_caption is encountered.
caption_frame_decode now always updates the timestamp of the
frame when the timestamp parameter != -1. This requires that callers
only pass a valid timestamp when a new one is encountered, for
example with SCC the timestamp at the start of the cue, then -1
until the next new timestamp.
A new enum member is added for the return value, LIBCAPTION_CLEAR.
It allows the caller to determine that closed captions should not
be displayed anymore, in order to finish the previous cue earlier
than the start of the next cue.