Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bitfields in caption_frame_cell_t and caption_frame_state_t s… #61

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Apr 14, 2020

  1. Replace bitfields in caption_frame_cell_t and caption_frame_state_t s…

    …tructs with uint8_t
    
    Contrary to what one might believe, this actually reduces the size of
    the structs due to alignment constraints. On Linux x86-64 clang/gcc it
    reduces the size of the caption_frame_t struct from 7760 bytes to 6800
    bytes, on Windows x86-64 MSVC from 11600 bytes to 6800 bytes.
    
    It also causes simpler and potentially faster assembly to be generated
    as the values can be directly accessed as uint8_t instead of having to
    extract the corresponding bits with bitwise operations.
    sdroege committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    37db117 View commit details
    Browse the repository at this point in the history