Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate test runner and other imrovements #57

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

danny0838
Copy link
Contributor

As explained in the commit messages.

@danny0838 danny0838 changed the title Separate test runner and minor changes Separate test runner and other imrovements Apr 6, 2024
@danny0838 danny0838 force-pushed the main branch 3 times, most recently from b84d3ff to 4ebbcc5 Compare April 7, 2024 06:48
@danny0838
Copy link
Contributor Author

Is there still some problem with these commits? It should be OK to merge this before #54 and #56, which I can rebase them afterwards.

@tabatkins
Copy link
Owner

Nope, it's purely been a matter of me not having the time to review them.

- Separate the test runner script to a new test.js file so that the developers of other projects can import and run the test cases on their own.
- This prevents the parseerror message show "0x-1".
- There is no \x00, which has been replaced during preprocessing, in the input codepoints.
- Wrap internal variables in a closure to prevent repeated instantiation when called.
- Define every internal function using a direct function expression rather than an anonymous function.
@danny0838
Copy link
Contributor Author

Rebased on top of #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants