Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Algolia GH action and wagmi example #197

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix Algolia GH action and wagmi example #197

merged 2 commits into from
May 9, 2024

Conversation

dtbuchholz
Copy link
Collaborator

@dtbuchholz dtbuchholz commented May 8, 2024 •
edited
Loading

Summary

  • wagmi/viem example was incorrect and had to be fixed
  • The Algolia reindexing was running in a GH action that executes on pushes to main. However, the actual site takes time to build, so the reindexing finishes before new content is materialized. This changes the action to wait for the production vercel deployment to finish and then reindexes thereafter.

@dtbuchholz dtbuchholz requested a review from joewagner May 8, 2024 22:02
joewagner
joewagner approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@joewagner joewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@dtbuchholz dtbuchholz merged commit b8fa975 into main May 9, 2024
2 checks passed
@dtbuchholz dtbuchholz deleted the dtb/fix-action-and-wagmi branch May 9, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewagner joewagner joewagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtbuchholz @joewagner