Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dependabot limit to 5 in each package #76

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

joewagner
Copy link
Collaborator

Summary

This PR ups the dependabot pr limit to 5 per package. I don't have much experience on how many dependabot prs are appropriate for the go package, so if anyone has an opinion we can change that.

Context

https://gap.gjensidige.io/docs/github/dependabot-for-internal-packages#:~:text=By%20default%2C%20Dependabot%20opens%20a,limit%20to%20change%20this%20limit.

Implementation overview

Our pre-monorepo npm based packages all allowed 5 dependabot PRs at a time, and this seems to me like the correct number. Now that this repo has both the go and npm package, the default number of dependabot prs per package was affectively reduced.

Checklist

  • Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
  • Are changes covered by existing tests, or were new tests included?
  • Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
  • Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

Copy link
Collaborator

@brunocalza brunocalza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good 👍

@joewagner joewagner merged commit d29d0f3 into main Jul 25, 2023
7 checks passed
@joewagner joewagner deleted the joe/dep-limit branch July 25, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants