Landing page #199

asutula · 2024-02-23T21:55:55Z

No description provided.

Signed-off-by: Aaron Sutula <[email protected]>

railway-app · 2024-02-23T21:56:05Z

This PR is being deployed to Railway 🚅

web: ◻️ REMOVED

Signed-off-by: Aaron Sutula <[email protected]>

asutula · 2024-02-26T18:08:36Z

packages/store/src/api/projects.ts

+    firstNProjectSlugs: async function (n: number) {
+      const res = await db
+        .select({ team: teams.slug, project: projects.slug })
+        .from(projects)
+        .innerJoin(teamProjects, eq(projects.id, teamProjects.projectId))
+        .innerJoin(teams, eq(teamProjects.teamId, teams.id))
+        .orderBy(projects.name)
+        .limit(n)
+        .all();
+      return res;
+    },
+
+    projectByTeamAndProjectSlugs: async function (
+      teamSlug: string,
+      projectSlug: string,
+    ) {
+      const res = await db
+        .select({ team: teams, project: projects })
+        .from(projects)
+        .innerJoin(teamProjects, eq(projects.id, teamProjects.projectId))
+        .innerJoin(teams, eq(teamProjects.teamId, teams.id))
+        .where(and(eq(teams.slug, teamSlug), eq(projects.slug, projectSlug)))
+        .get();
+      return res;
+    },
+
+    latestProjects: async function (offset: number, count: number) {
+      const res = await db
+        .select({ projects, teams })
+        .from(projects)
+        .innerJoin(teamProjects, eq(projects.id, teamProjects.projectId))
+        .innerJoin(teams, eq(teamProjects.teamId, teams.id))
+        .where(isNotNull(projects.createdAt))
+        .orderBy(desc(projects.createdAt))
+        .offset(offset)
+        .limit(count)
+        .all();
+      return res.map((r) => ({ team: r.teams, project: r.projects }));
+    },
+


Some new sore functions for populating the landing page.

asutula · 2024-02-26T18:09:59Z

...s/web/app/[team]/[project]/(project)/deployments/[[...slug]]/_components/exec-deployment.tsx

+          <ChainSelector
+            onValueChange={(val) => {
+              if (typeof val === "number") {
+                setChainId(val);
+              }
+            }}
+            disabled={pendingDeploy}
+          />


I updated the ChainSelector component to optionally support selecting "all testnets" and "all mainnets", so uses of this component need to be updated to handle those new values in the callback.

asutula · 2024-02-26T18:10:32Z

packages/web/app/_components/latest-projects.tsx

Component to display latest projects on the landing page.

asutula · 2024-02-26T18:11:05Z

packages/web/app/_components/latest-tables.tsx

Component to display latest tables on the landing page.

asutula · 2024-02-26T18:11:42Z

packages/web/app/_components/paginator.tsx

Reusable component to move forwards and backwards through paginated data.

asutula · 2024-02-26T18:17:32Z

packages/web/components/ui/dialog.tsx

Had to update to the latest shadcn component version here to be compatible with a radix ui update that was introduced by installing the Alert component.

asutula · 2024-02-26T18:18:08Z

packages/web/lib/featured-projects.ts

+export async function featuredProjectSlugs() {
+  if (process.env.NODE_ENV === "development") {
+    return await store.projects.firstNProjectSlugs(5);
+  } else if (process.env.SITE_DOMAIN?.includes("staging")) {
+    return [
+      { team: "aaron", project: "four-project" },
+      { team: "joe", project: "students" },
+      { team: "aaron", project: "with-timestamp" },
+    ];
+  } else {
+    return [];
+  }
+}


This is where we configure featured projects. cc @dtbuchholz.

asutula · 2024-02-26T18:18:46Z

packages/web/lib/validator-queries.ts

These are a couple functions that wrap the validator /query endpoint to get data for the landing page.

asutula · 2024-02-26T18:19:11Z

packages/web/lib/wallet.ts

@@ -1,5 +1,5 @@
 import { Wallet, getDefaultProvider } from "ethers";
-import { NonceManager } from "@tableland/nonce";
+import { NonceManager } from "@ethersproject/experimental";


Temporary change until we're ready for redis nonce manager.

asutula · 2024-02-26T18:20:02Z

packages/web/scripts/validator/config.json

+        "MinBlockDepth": 1,
+        "PersistEvents": true


Updated our local tableland validator config to persist event data so we can use it during development.

Signed-off-by: Aaron Sutula <[email protected]>

joewagner

@asutula Great work! I have a few suggestions, and comments. In case you want to get this out as is for EthDen I'll approve, if not, I'm happy to jump in voice tomorrow to discuss.

joewagner · 2024-02-26T22:35:37Z

packages/cli/.env.example

@@ -1,4 +1,3 @@
-API_PRIVATE_KEY=0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d


Instead of deleting, we probably want this to be STORE_PRIVATE_KEY right?

joewagner · 2024-02-26T22:50:13Z

packages/web/app/_components/latest-tables.tsx

+        setLoading(false);
+      });
+    }
+    fetchLatestTables().catch(() => {});


We should probably do something with this error. Maybe notify the user that we couldn't load the latest tables, or log to the console? Also, inside the catch function we should probably do setLoading(false) since the loading is finished and the body of the above then function won't be called.

joewagner · 2024-02-26T22:52:01Z

packages/web/app/_components/latest-tables.tsx

+  useEffect(() => {
+    async function fetchLatestTables() {
+      setLoading(true);
+      await getLatestTables(selectedChain).then((tables) => {


Can we do const tables = await getLatestTables(selectedChain); instead of mixing await and then?

joewagner · 2024-02-26T22:55:51Z

packages/web/app/page.tsx

+      });
+    } catch {
+      // This is fine, we just don't have any teams if the user
+      // is unauthorized or some other error happens.


Should we log the error to the console?

joewagner · 2024-02-26T23:00:32Z

packages/web/components/chain-selector.tsx

+    if (val === "mainnets" || val === "testnets") {
+      onValueChange(val);
+    } else {
+      onValueChange(parseInt(val, 10));


Not sure what possible values of val could be called here, but if "" or undefined make it here this will be NaN. Is that ok?

joewagner · 2024-02-26T23:49:10Z

packages/web/app/_components/popular-tables.tsx

+        </div>
+        <div className="ml-auto flex items-center gap-2">
+          <Label>Chain:</Label>
+          <ChainSelector


Just noticing that when I change chains, the pagination isn't reseting. This means if I'm looking at page 2 of "all testnets" and I switch to "all mainnets", it's a blank list. If I notice that the pagination says "2", i'd be able to figure out how to get back to the list of popular mainnet tables, but if not, it looks like there aren't any tables.

Same goes for the Latest Tableland tables pagination.

Signed-off-by: Aaron Sutula <[email protected]>

asutula · 2024-02-27T15:30:22Z

All really good feedback @joewagner. I fixed all the things you mentioned, take a look.

joewagner · 2024-02-27T15:40:51Z

@asutula Nice work! The approval still looks good, merge away!

Working landing page

14678ad

Signed-off-by: Aaron Sutula <[email protected]>

asutula self-assigned this Feb 23, 2024

asutula added 6 commits February 23, 2024 16:34

coming soon alert

c200047

Signed-off-by: Aaron Sutula <[email protected]>

update shad dialog

3ebaea1

Signed-off-by: Aaron Sutula <[email protected]>

default to testnets

569f022

Signed-off-by: Aaron Sutula <[email protected]>

really make testnets default

c0cdf4a

Signed-off-by: Aaron Sutula <[email protected]>

featured projects grid, copy tweaks

b8a7857

Signed-off-by: Aaron Sutula <[email protected]>

empty featured projects for prod

ba18bf4

Signed-off-by: Aaron Sutula <[email protected]>

asutula commented Feb 26, 2024

View reviewed changes

build workflow

45ed8d2

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 19:43 — with GitHub Actions Inactive

lint fixes

da0f087

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 20:42 — with GitHub Actions Inactive

remove dup private key env var

74430e9

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 21:18 — with GitHub Actions Inactive

use npm scripts in workflows

0fecf2a

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 21:30 — with GitHub Actions Inactive

refactor workflows

e25e8d6

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 21:36 — with GitHub Actions Inactive

fix job names

1ba1c0d

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 21:43 — with GitHub Actions Inactive

build:ci

ae4a189

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 21:55 — with GitHub Actions Inactive

skip building web for test workflow

d88ff9d

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 22:22 — with GitHub Actions Inactive

asutula marked this pull request as ready for review February 26, 2024 22:28

asutula requested a review from joewagner February 26, 2024 22:29

remove npm script

f566130

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 26, 2024 22:32 — with GitHub Actions Inactive

joewagner approved these changes Feb 27, 2024

View reviewed changes

pr feedback changes

24a2664

Signed-off-by: Aaron Sutula <[email protected]>

asutula temporarily deployed to staging February 27, 2024 15:30 — with GitHub Actions Inactive

asutula merged commit b6a490e into staging Feb 27, 2024
4 checks passed

asutula deleted the landing-page branch February 27, 2024 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Landing page #199

Landing page #199

asutula commented Feb 23, 2024

railway-app bot commented Feb 23, 2024 •

edited

Loading

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

asutula Feb 26, 2024

joewagner left a comment

joewagner Feb 26, 2024

joewagner Feb 26, 2024

joewagner Feb 26, 2024

joewagner Feb 26, 2024

joewagner Feb 26, 2024

joewagner Feb 26, 2024

joewagner Feb 26, 2024

asutula commented Feb 27, 2024 •

edited

Loading

joewagner commented Feb 27, 2024

		@@ -1,4 +1,3 @@
		API_PRIVATE_KEY=0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d

Landing page #199

Landing page #199

Conversation

asutula commented Feb 23, 2024

railway-app bot commented Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joewagner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asutula commented Feb 27, 2024 • edited Loading

joewagner commented Feb 27, 2024

railway-app bot commented Feb 23, 2024 •

edited

Loading

asutula commented Feb 27, 2024 •

edited

Loading