Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to ethers v6, wagmi/viem/rainbowkit v2 #125

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

dtbuchholz
Copy link
Contributor

@dtbuchholz dtbuchholz commented Apr 26, 2024

Summary

Bumps to new SDK, ethers, and wagmi/viem/rainbowkit v2. Closes ENG-843.

Note: we need to add a WALLET_CONNECT_PROJECT_ID env var to this repo due to the newer versions requiring this. I don't have the ability to do that.

Details

The only real changes are in app/components/Providers.tsx. Everything else is eslint fixing files that never got linted.

@dtbuchholz dtbuchholz requested a review from asutula April 26, 2024 18:20

// All of the chains configured below are supported by Tableland
// @ts-expect-error this is valid; the OP chains cause a type error
const chains: readonly [Chain, ...Chain[]] = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the bulk of the changes—it's just updating to the lastest wagmi etc setup and includes all of the newest chains

@dtbuchholz
Copy link
Contributor Author

dtbuchholz commented May 7, 2024

note: i removed node 16 from GH actions since we did that in other packages, too. but, it looks like the workflows prior to making that change are hanging this up.

@joewagner
Copy link
Contributor

note: i removed node 16 from GH actions since we did that in other packages, too. but, it looks like the workflows prior to making that change are hanging this up.

Something weird going on there. test (16) shouldn't be running since you removed it in this PR, and lint is just hanging.
Maybe we wait a while and if it's still not mergeable someone with admin privileges can force merge?

@dtbuchholz dtbuchholz merged commit a5cbf74 into main May 9, 2024
5 checks passed
@dtbuchholz dtbuchholz deleted the dtb/ethers-v6 branch May 9, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants