Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove .readTuple() from non-opt tuple reading #692

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: remove .readTuple() from non-opt tuple reading #692

merged 2 commits into from
Aug 15, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Aug 15, 2024 •
edited
Loading

Closes #690

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.4.3 milestone Aug 15, 2024
@Gusarich Gusarich requested a review from anton-trunov August 15, 2024 07:45
@anton-trunov anton-trunov self-assigned this Aug 15, 2024
@anton-trunov anton-trunov merged commit 799b0c3 into tact-lang:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

Getters cannot work as before that in case of multi level nested structs with optional fileds.
2 participants
@Gusarich @anton-trunov