Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error message if constant shadows stdlib identifier #694

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: better error message if constant shadows stdlib identifier #694

merged 1 commit into from
Aug 15, 2024

Conversation

anton-trunov
Copy link
Member

Closes #691

  • I have updated CHANGELOG.md
  • [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.3 milestone Aug 15, 2024
@anton-trunov anton-trunov self-assigned this Aug 15, 2024
@anton-trunov anton-trunov merged commit 0579766 into main Aug 15, 2024
3 checks passed
@anton-trunov anton-trunov deleted the fix-error-message-for-const-shadowing branch August 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeshecdom jeshecdom jeshecdom approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

Declared global constants may clash with local variables in stdlib functions
2 participants
@anton-trunov @jeshecdom