Sop for javac's --release 6 check #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in issue #235, the --release option in newer javac versions will check against a ct.sym file included in the jdk that is meant to record what API was available in which prior releases, and that file (at least as shipped in Java 11) is missing the newFactory() methods on XMLInputFactory and XMLOutputFactory for release 6, so it reports them not found. Happily, both no-arg newFactory() methods are equivalent to the no-arg newInstance() methods. Deprecation tags were added to the newInstance(String,ClassLoader) methods, but not to the no-arg ones.
jcflack
added a commit
that referenced
this pull request
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #235, the
--releaseoption in newerjavacversions will check against a
ct.symfile included in the jdkthat is meant to record what API was available in which prior
releases, and that file (at least as shipped in Java 11) is
missing the
newFactory()methods onXMLInputFactoryandXMLOutputFactoryfor release 6, so it reports them not found.Happily, both no-arg
newFactory()methods are equivalent tothe no-arg
newInstance()methods. Deprecation tags were addedto the
newInstance(String,ClassLoader)methods, but not tothe no-arg ones.