Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon-doc): improve UX when switch global dark mode on API page #9053

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat(addon-doc): improve UX when switch global dark mode on API page #9053

merged 1 commit into from
Sep 26, 2024

Conversation

splincode
Copy link
Member

No description provided.

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 16, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ec33095):

https://taiga-previews--pr9053-splincode-addon-doc-ychu8cbr.web.app

(expires Fri, 27 Sep 2024 15:09:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 16, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 287.8KB (+64B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 247.13KB +10%
✅ demo/browser/runtime.(hash).js
 42.69KB +10%
✅ demo/browser/styles.(hash).css
 16.17KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +64B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.14MB (+64B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@taiga-family taiga-family deleted a comment from waterplea Sep 23, 2024
@splincode splincode force-pushed the splincode/addon-doc-theme-dark branch 2 times, most recently from 648732c to 90f83f7 Compare September 26, 2024 10:57
@splincode splincode enabled auto-merge (squash) September 26, 2024 15:23
@splincode splincode merged commit f9579da into main Sep 26, 2024
27 checks passed
@splincode splincode deleted the splincode/addon-doc-theme-dark branch September 26, 2024 15:24
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 30, 2024
Merged
This was referenced Oct 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@mdlufy mdlufy Awaiting requested review from mdlufy

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@splincode splincode

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@splincode @waterplea @nsbarsukov @vladimirpotekhin