Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon-doc): add aria-label for dark mode button #9108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(addon-doc): add aria-label for dark mode button #9108

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

@splincode splincode commented Sep 19, 2024 •
edited
Loading

Before

image

After

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 19, 2024 •
edited
Loading

Tests completed successfully ✅

Good job 🔥

@github-actions github-actions bot added the v4 4.0 candidate label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit a3a7231):

https://taiga-previews--pr9108-splincode-demo-1-5pnbby5i.web.app

(expires Fri, 20 Sep 2024 19:45:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 19, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 287.35KB (+26B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 247.15KB +10%
✅ demo/browser/runtime.(hash).js
 42.32KB +10%
✅ demo/browser/styles.(hash).css
 16.18KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

Total files change +26B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.05MB (+26B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode changed the title chore(demo): add aria-label for dark mode button feat(addon-doc): add aria-label for dark mode button Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@splincode splincode

Labels
v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@splincode