Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix example using the prove-block.sh #268

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/README_Docker_and_RA.md
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ Once your Raiko instance is running, you can verify if it was started properly a
}'
```

Or use `./script/prove-block` like `./script/prove-block.sh taiko_a7 native 99999` to check readiness.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running the native to "check for readiness" means to make sure the host & block builder without any proof, so it should not be sgx

Copy link
Author

@mavroudisv mavroudisv Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I wrong to assume that in this case the response shouldn't include a proof?

This is the example response the docs provide.

The response should look like this:

{
    "data": {
        "output": null,
        "proof": "0x00000206c3694ecb5c....6e0e7a36546bf98caa7bb4ac2cd4f917c2102116167e42c54849f15044c032e1c",
        "quote": "03000200000000000a000f00939a72....0a2d2d2d2d2d454e442043455254494649434154452d2d2d2d2d0a00"
    },
    "status": "ok"
}

If so, I can edit the PR to match the expected (no proof) output.

Or use `./script/prove-block.sh` like `./script/prove-block.sh taiko_a7 sgx 99999` to check readiness.


The response should look like this:
Expand Down
Loading