-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): preconfs #281
base: taiko
Are you sure you want to change the base?
feat(all): preconfs #281
Conversation
Could you create a new API? But not break eth's origin |
this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement? |
Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed. |
I agree to use a new API. |
Lets keep these changes in another branch instead of |
@@ -160,6 +160,9 @@ type Config struct { | |||
|
|||
// OverrideVerkle (TODO: remove after the fork) | |||
OverrideVerkle *uint64 `toml:",omitempty"` | |||
|
|||
// change(taiko): preconf url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// change(taiko): preconf url | |
// CHANGE(taiko): preconf url |
@@ -252,7 +255,8 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) { | |||
eth.miner = miner.New(eth, &config.Miner, eth.blockchain.Config(), eth.EventMux(), eth.engine, eth.isLocalBlock) | |||
eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData)) | |||
|
|||
eth.APIBackend = &EthAPIBackend{stack.Config().ExtRPCEnabled(), stack.Config().AllowUnprotectedTxs, eth, nil} | |||
// change(TAIKO): preconfirmation URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// change(TAIKO): preconfirmation URL | |
// CHANGE(taiko): preconfirmation URL |
@@ -101,6 +101,9 @@ type Ethereum struct { | |||
lock sync.RWMutex // Protects the variadic fields (e.g. gas price and etherbase) | |||
|
|||
shutdownTracker *shutdowncheck.ShutdownTracker // Tracks if and when the node has shutdown ungracefully | |||
|
|||
// change(taiko) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -423,6 +423,7 @@ func (c *BoundContract) transact(opts *TransactOpts, contract *common.Address, i | |||
if opts.NoSend { | |||
return signedTx, nil | |||
} | |||
// change(taiko): slot and sig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -180,6 +180,7 @@ var ( | |||
utils.AllowUnprotectedTxs, | |||
utils.BatchRequestLimit, | |||
utils.BatchResponseMaxSize, | |||
utils.PreconfirmationForwardingURLFlag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils.PreconfirmationForwardingURLFlag, | |
utils.PreconfirmationForwardingURL, |
@@ -0,0 +1,25 @@ | |||
./build/bin/geth \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this script?
Unless it is a version upgradation, please do not add extra logs or blank lines in unmodified areas. |
if err != nil { | ||
return nil, NewTxIndexingError() // transaction is not fully indexed | ||
if err != nil || !found { | ||
// change(taiko): check to see if it exists from the preconfer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Please use the unique |
yep, when this PR is ready for review I'll tag you, it's just constant crap rn because I push changes to log and test stuff. |
No description provided.