feat(taiko-client): enable proof aggregation (batch proofs) #18163
+1,295
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoGhurt111
commented
Sep 23, 2024
feat(taiko-client): submit batch proofs
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
…hub.com:taikoxyz/taiko-mono into feature/batch-proof
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
packages/taiko-client/prover/proof_submitter/transaction/builder.go
Outdated
Show resolved
Hide resolved
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
…er.go Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
| @@ -2,7 +2,7 @@ name: "Build and Push Multi-Arch Docker Image" | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [main] | |||
| branches: [feature/batch-proof] | |||
There was a problem hiding this comment.
I want to build a new image to test in devnet first and then I will change it back.
| result = make([]*BlockProofStatus, len(ids)) | ||
| ) | ||
| // Get the local L2 parent header. | ||
| g, gCtx := errgroup.WithContext(ctxWithTimeout) |
There was a problem hiding this comment.
And after thinking twice, let's do batch requests https://geth.ethereum.org/docs/interacting-with-geth/rpc/batch here and some other places, to make the network requests always O1.
There was a problem hiding this comment.
OK, pretty good!
| continue | ||
| } | ||
| g.Go(func() error { | ||
| header, err := cli.WaitL2Header(gCtx, ids[i]) |
There was a problem hiding this comment.
We can just wait for the highest header here right? no need to send requests to check and wait every block?
| } | ||
|
|
||
| // Get the corresponding L2 block. | ||
| block, err := s.rpc.L2.BlockByHash(ctx, proof.Header.Hash()) |
There was a problem hiding this comment.
Lets also use batch requests here.
packages/taiko-client/prover/proof_submitter/transaction/sender.go
Outdated
Show resolved
Hide resolved
…r.go Co-authored-by: David <[email protected]>
packages/taiko-client/prover/proof_submitter/transaction/sender.go
Outdated
Show resolved
Hide resolved
…r.go Co-authored-by: David <[email protected]>
YoGhurt111
commented
Nov 20, 2024
packages/taiko-client/prover/proof_submitter/transaction/sender.go
Outdated
Show resolved
Hide resolved
…r.go Co-authored-by: Gavin Yu <[email protected]>
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
This reverts commit ff2228b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.