Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funnel functionality to C library #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mastermakrela
Copy link
Contributor

@mastermakrela mastermakrela commented Jan 19, 2025

While working on Tailscale in js1 I've noticed that while tailscale server equivalent was present, tailscale funnel was missing, although it's available in the underlying tsnet library.

This PR exposes it to be usable from C.

Contributions:

  1. tailscale_listen_funnel — starts a funnel instead of tailnet only listener, otherwise equivalent to tailscale_listen

  2. tailscale_cert_domains — retrieves the domain name under which the funnel is accessible. nice to have for better terminal message

  3. tailscale_accept_nonblocking — not directly connected to the funnel, but helpful for not blocking the js event loop with tailscale_accept

Also, as I was editing it anyway, I've also fixed some typos in tailscale.h.


I see there is a failing check, but I can't see the whole message. Please let me know what I have to correct and I'll gladly do it. :)


Footnotes

  1. PR is a possible future work, but currently FFI in JS is not really standardized. So I've made a separate repo for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant