Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Important Selector Strategy to apply styles to wrapper component also #14734

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nickfujita
Copy link

@nickfujita nickfujita commented Oct 21, 2024

Enables tailwind styles to also be applied to the wrapper component containing the important selector.

  • Adds the wrapper element with the selector to also be included in the output styles.
  • Adjusts removal of important selector before reapplication for @apply selectors

More info
#14735

@nickfujita nickfujita marked this pull request as ready for review October 21, 2024 09:13
@nickfujita nickfujita requested a review from a team as a code owner October 21, 2024 09:13
@RobinMalfait RobinMalfait self-assigned this Oct 21, 2024
@nickfujita
Copy link
Author

@RobinMalfait Thanks for self assigning this one. I was able to resolve the issue with the one test not passing that I originally had. All tests are now passing.

@nickfujita
Copy link
Author

Hey @RobinMalfait just wanted to see if I could follow up with you on this enhancement. We've been using our fork successfully with these changes, and would love to get back to main branch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants