Hide action bar to avoid shadow creeping into images captured using captureRoboImage #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't notice this. Looks great! |
|
@lukas-mercari Thanks for your contribution! |
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Apr 12, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.11.0` -> `1.12.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.11.0` -> `1.12.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.11.0` -> `1.12.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.11.0` -> `1.12.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.12.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.12.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.11.0...1.12.0) ##### Bug Fixes - Fixed an issue where recorded images with a transparent background and a scaling option (e.g., 0.5F) were always detected as changes. Thanks for reporting this, [@​yongsuk44](https://togithub.com/yongsuk44)! - Addressed a bug related to `robolectric.screenshot.hwrdr.native` introduced in [Robolectric 4.12](https://togithub.com/takahirom/roborazzi/issues/296#issuecomment-2049440301), which caused unwanted shadows when using Compose's `roboCaptureImage{}` with this new option. This has now been corrected by [@​lukas-mercari](https://togithub.com/lukas-mercari). Thanks for your contribution! ##### What's Changed - Hide action bar to avoid shadow creeping into images captured using captureRoboImage by [@​lukas-mercari](https://togithub.com/lukas-mercari) in [https://github.com/takahirom/roborazzi/pull/283](https://togithub.com/takahirom/roborazzi/pull/283) - \[CI]Compare with base branch by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/284](https://togithub.com/takahirom/roborazzi/pull/284) - update robolectric version from 4.10.3 to 4.12.1 by [@​sanao1006](https://togithub.com/sanao1006) in [https://github.com/takahirom/roborazzi/pull/289](https://togithub.com/takahirom/roborazzi/pull/289) - Add roundTransparentResizeCompose test by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/297](https://togithub.com/takahirom/roborazzi/pull/297) - Fix false positive issue in verification of scaled transparent images by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/298](https://togithub.com/takahirom/roborazzi/pull/298) ##### New Contributors - [@​lukas-mercari](https://togithub.com/lukas-mercari) made their first contribution in [https://github.com/takahirom/roborazzi/pull/283](https://togithub.com/takahirom/roborazzi/pull/283) **Full Changelog**: takahirom/roborazzi@1.11.0...1.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODcuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI4Ny4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out shadow rendering as outlined in #273 and noticed that there's a shadow from the top when using
captureRoboImagewith a composable parameter. This is visible in the diff formanual_composein #273.It seems that it's caused by the action bar of
RoborazziTransparentActivityrendering right above the composable and thus "leaking" a shadow into the screenshot.I tested the change by applying it on top of #273.