-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - RNG Emulator #387
base: main
Are you sure you want to change the base?
POC - RNG Emulator #387
Conversation
# Conflicts: # gradle.properties # gradle/libs.versions.toml
For discussion only at the moment, happy to close, but wanted to see if it's viable. |
@yschimke Maybe like this?
And then run the |
At the moment it's clunky. I'm running the server in junit temporarily. It saves implementing all the sandbox config logic for a POC. So run the testServer unit test method, it will print out it's started on port 8080. Then run ClientMain. I had to turn off building the project on launch otherwise it waits for the unit test to finish which never does. Sorry it's in such a rough state, but wanted to discuss the approach first |
I believe the main point would be to provide an interface shared with the Android Emulator. It sounds very promising. I tried using the android-emulator-webrtc, but setting it up with SSL and CORS is a bit difficult. It would be great if we could avoid these issues for users. |
@takahirom what I might try is a minimal project, outside roborazzi. One composable, one preview. Implement there and include a web page, showing android-emulator-webrtc. This is probably a slow burner project, but wanted to see if it aligns with what you were envisioning. |
Thanks. I think there are two use cases for the RNG emulator:
Sharing an interface with the emulator isn't necessary, but it would be intuitive to use the emulator in the usual way for debugging. There may be some challenges, however. If this becomes a blocker, we can proceed without the interface. |
@takahirom I like that scope, it actually brings it inline with the POC. running within the test runner actually makes sense then. So maybe at the start of a run, I'll print out the URL for a hosted webserver, and opening that will show you the internal progress? |
Sounds good! So, you might run two servers, like a gRPC server and a web server, right? |
ClientMain (Client -> gRPC -> Server) spits out a similar PNG for SimplePreview, that running on an emulator does.
Quick and dirty POC for an alternative approach to #176
Current Hacks
Todo (after some discussion)