Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2025 01 fixed dbio warning #351

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Refactor/2025 01 fixed dbio warning #351

merged 3 commits into from
Jan 2, 2025

Conversation

takapi327
Copy link
Owner

@takapi327 takapi327 commented Jan 2, 2025 •
edited
Loading

Implementation Details

  • Remove type parameter constraints from DBIO
  • Renamed from execute function to run function
  • Remove duplicate Functor implementations

Fixes

Fixed a warning that occurred when updating to Scala 3.6.x series with the following pull request

#335

Relevant Actions: https://github.com/takapi327/ldbc/actions/runs/12562908297/job/35024021510?pr=335

Pull Request Checklist

  • Wrote unit and integration tests
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code formatting by scalafmt (sbt scalafmtAll command execution)
  • Add copyright headers to new files

References

@takapi327 takapi327 added 🔧 refactor Refactoring project:dsl Addition and modification of functionality to DSL projects labels Jan 2, 2025
@takapi327 takapi327 added this to the 0.3.0 milestone Jan 2, 2025
@takapi327 takapi327 self-assigned this Jan 2, 2025
@takapi327 takapi327 merged commit 12f3b56 into master Jan 2, 2025
27 checks passed
@takapi327 takapi327 deleted the refactor/2025-01-Fixed-DBIO-warning branch January 2, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@takapi327 takapi327

Labels
project:dsl Addition and modification of functionality to DSL projects 🔧 refactor Refactoring
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@takapi327