Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestLockTTL #123

Closed
wants to merge 1 commit into from
Closed

Fix TestLockTTL #123

wants to merge 1 commit into from

Conversation

czt1999
Copy link

@czt1999 czt1999 commented Apr 13, 2022

fix #122

  1. Add elapsedUnit for ease of correcting calculation of TTL in TestLockTTL without effect on other implementations
  2. Convert x and y to float64 ahead of subtraction in ttlEquals

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@czt1999
Copy link
Author

czt1999 commented Apr 23, 2022

Refered to https://github.com/tiny-talent/distributed-txn, computing elapsed before prewrite can simply solve the problem. So this PR is closed.

@czt1999 czt1999 closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix lock_test.go/TestLockTTL
2 participants
@czt1999 @CLAassistant