Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URL in README #63

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Conversation

TennyZhuang
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2020

CLA assistant check
All committers have signed the CLA.

@tisonkun
Copy link
Contributor

tisonkun commented Sep 7, 2021

@TennyZhuang please sign CLA and we can proceed.

@TennyZhuang
Copy link
Contributor Author

@TennyZhuang please sign CLA and we can proceed.

Done

@tisonkun
Copy link
Contributor

tisonkun commented Sep 7, 2021

@rebelice do you have an idea why "Build & Test" doesn't run?

@tisonkun tisonkun closed this Oct 1, 2021
@tisonkun tisonkun reopened this Oct 1, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Oct 1, 2021

It seems the workflow configures wrongly. Let me try to fix it.

@tisonkun
Copy link
Contributor

tisonkun commented Oct 1, 2021

It is too complex to a course IMO. The Makefile is quite outdated and also the code. I don't want to fix them anyway.

cc @zhangyangyu @rebelice you may take a look at this issue. The build system of tinysql is quite mess.

@rebelice
Copy link
Collaborator

rebelice commented Oct 1, 2021

It's too hard to fix Build & Test. As far as I know, CI will keep failing until the entire tinysql is completed.

@tisonkun
Copy link
Contributor

tisonkun commented Oct 1, 2021

@rebelice I agree. Any progress on #83 ?

@rebelice
Copy link
Collaborator

rebelice commented Oct 1, 2021

@tisonkun Yes, I'm working on pushing the first PR. You may see it later.

@tisonkun tisonkun mentioned this pull request Oct 3, 2021
@tisonkun tisonkun merged commit 1f08cee into talent-plan:course Oct 11, 2021
@tisonkun
Copy link
Contributor

@TennyZhuang thanks for your contribution. Although I think the contribution guide should be updated later.

@tisonkun
Copy link
Contributor

Contribution guides of tinysql & tidb are different also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants