Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed images #18

Open
KevinGDialpad opened this issue May 28, 2022 · 0 comments · May be fixed by #21
Open

Embed images #18

KevinGDialpad opened this issue May 28, 2022 · 0 comments · May be fixed by #21
Assignees
@KevinGDialpad
Labels
enhancement New feature or request

Comments

@KevinGDialpad
Copy link
Contributor

Similar to #8, but a bit more complicated.

The JIRA markdown for images is !some_pic.png! or !some_pic.png|alt=image!.

We need to get the actual image URL from GitHub.
@KevinGDialpad KevinGDialpad added the enhancement New feature or request label May 28, 2022
This was referenced May 28, 2022
Closed
Merged
KevinGDialpad added a commit that referenced this issue Jun 3, 2022
@KevinGDialpad
feat: Handle relative links properly (#20)
a9fbce4 
This handles relative links like `../src/my_source_file.py` that previously resulted in dead links once on Confluence.

Relative links are now replaced with GitHub links. If the file has an associated Confluence page, it links to that instead.

This doesn't handle images (#18) nor unnamed links (#19).
@KevinGDialpad KevinGDialpad self-assigned this Jun 3, 2022
@KevinGDialpad KevinGDialpad mentioned this issue Jun 3, 2022
Open
@KevinGDialpad KevinGDialpad linked a pull request Jun 11, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinGDialpad KevinGDialpad

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#18 Embed images talkiq/confluence-wiki-sync
1 participant
@KevinGDialpad