#18 Embed images #21
Draft
#18 Embed images #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review! The reviewer will once again be next-week-Kevin, who will also create tickets for the TODOs and link them in the code, and make the 1.2 release. |
Open
|
Just realized that I'd only tested this by adding images to existing pages. It doesn't work when adding a new document with an image, because the logic that adds attachments runs inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18, #19
The idea is to attach the file to the wiki page. The tricky bit will be to figure out when to update it (what if you update an image but not the document(s) that use it?), but we can worry about that later. Having an initial version of the image is better than the current situation.