Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functionality to escape items in the markdown which look like … #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clivedavies-cpi
Copy link

…XHTML macros.

So ${SOME_VARIABLE} becomes ${SOME_VARIABLE}

Without this change the Confluence page creation can fail, in our case because we had fenced code blocks containing fragments of bash scripts.

…XHTML macros.

So ${SOME_VARIABLE} becomes $\{SOME_VARIABLE\}

Without this change the Confluence page creation can fail, in our case because we had
fenced code blocks containing fragments of bash scripts.
@clivedavies-cpi
Copy link
Author

I had to fix this for our use case and thought it might be helpful for others

@KevinGDialpad
Copy link
Contributor

Oh, amazing, I didn't know anyone else was using this! Thanks for sharing your fix.

Would you mind running pre-commit run --all-files and looking at the pylint errors? I think we've gotten to the point where the get_formatted_file_content() method is too complex.

Also if you have a minute, I'd love it if you could write a test for your change, similar to the existing test_http_link(). Either in a new test file or in the existing test_relative_links.py (with a new file name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants