Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataBlocks for rotation and scaling #8

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Add DataBlocks for rotation and scaling #8

merged 4 commits into from
Jul 22, 2023

Conversation

gitttt-1234
Copy link
Contributor

Rotation and scaling Augmentations using Kornia

@gitttt-1234 gitttt-1234 requested a review from talmo July 21, 2023 19:07
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e579925). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 9d2ceb2 differs from pull request most recent head e880293. Consider uploading reports for the commit e880293 to get more accurate results

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   95.34%           
=======================================
  Files           ?        4           
  Lines           ?       43           
  Branches        ?        0           
=======================================
  Hits            ?       41           
  Misses          ?        2           
  Partials        ?        0           
Impacted Files Coverage Δ
sleap_nn/data/augmentation.py 100.00% <100.00%> (ø)
sleap_nn/data/providers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@talmo talmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but two things:

  1. While David works on Add centroid finder block #7, do you mind merging it into this branch or just copying the new structure for LabelsReader from here? It works at the frame-level now instead of instance-level.
  2. Do you have pydocstyle in vscode? It looks like some of your docstrings are going over 88 characters per line. Ignore if I'm just eyeballing that wrong.

@gitttt-1234
Copy link
Contributor Author

Sure, I'll merge my code with #7. I dont think I have pydocstyle, I'll check and add it now

@talmo talmo merged commit df2386d into main Jul 22, 2023
@talmo talmo deleted the divya/rotations branch July 22, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants