Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring trait pipeline (2/2) #48

Merged
merged 42 commits into from
Aug 2, 2023
Merged

Refactoring trait pipeline (2/2) #48

merged 42 commits into from
Aug 2, 2023

Conversation

eberrigan
Copy link
Collaborator

No description provided.

@eberrigan
Map convex hull traits
98ce00c
@eberrigan
Change primary to lateral when monocots is True
d6bd4bb
@eberrigan
Get tips x and y coordinates uses network map
4d7bc4d
@eberrigan
Change "stem" to "root"
51d60ab
@eberrigan
Fix tip y map
a73ebcd
@eberrigan
Change root width back to take lateral_pts
fc155f8
@eberrigan
Changing the order of positional arguments to match others (primary i…
ff9530d 
…s first)
@eberrigan
Fix plotting for using sleap-io API
c6e58a3
@eberrigan
Merge branch 'elizabeth/fix_plotting' into elizabeth/pipeline_cache
1bd4ddd
@eberrigan
Make positional arguments consistent
25e1047
@eberrigan
Refactor get_base_xs to use graph
eb973bd
@eberrigan
Map scanline_intersection_counts and use keyword arguments
fd30b78
@eberrigan
Refactor get_base_ys, get_base_length, and base_ct_density to u…
4b529ae 
…se graph and add comments. Delete duplicate `primary_depth`.
@eberrigan
Clean up dependencies. Fix tip_ys.
296fcc7
@eberrigan
Refactor get_root_lengths_max for use with graph
8f8a39a
@eberrigan
Refactor get_base_tip_dist to make base and tip pts or all points o…
a25e8b9 
…ptional arguments
@eberrigan
Delete primary_depth
01ea8bc
@eberrigan
Delete traitsgraph
617f379
@eberrigan
Delete traitsgraph dependencies
383d454
@eberrigan
Refactor base-related traits to use graph optionally
132ac7e
@eberrigan
Delete traits graph dependency
3f3967f
@eberrigan
Use get_primary_pts from series class
2f9465f
@eberrigan
Delete get_primary_depth tests
7cf6817
@eberrigan
Fix trait map for base traits
2f64aaf
@eberrigan
Delete test for traitsgraph.py
a88dafc
talmo
talmo requested changes Jul 28, 2023
View reviewed changes
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
sleap_roots/bases.py Outdated Show resolved Hide resolved
@linwang9926 linwang9926 merged commit 72577c8 into lin/pipeline_cache Aug 2, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talmo talmo talmo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eberrigan @talmo @linwang9926