-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyter notebooks for code instruction #72
Conversation
Warning Rate Limit Exceeded@eberrigan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update introduces a new Jupyter notebook, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- notebooks/MultipleDicotPipeline.ipynb (1 hunks)
- pyproject.toml (1 hunks)
Additional Context Used
Additional comments not posted (3)
notebooks/MultipleDicotPipeline.ipynb (3)
4-18
: The imports are well-organized and appropriate for the tasks demonstrated in the notebook.
22-30
: The paths for CSV and folder locations are hardcoded, which might limit the notebook's usability in different environments or datasets. Consider making these paths configurable, for example, by using input fields or environment variables, to enhance the notebook's flexibility.
34-52
: The operation to find all h5 files is correctly implemented. However, consider adding error handling or feedback for cases where no h5 files are found, to improve the user experience. For example, you could add a conditional check onall_h5s
and print a message if it's empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- notebooks/MultipleDicotPipeline.ipynb (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- notebooks/MultipleDicotPipeline.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- notebooks/MultipleDicotPipeline.ipynb (1 hunks)
- pyproject.toml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- notebooks/MultipleDicotPipeline.ipynb
- pyproject.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 74.90% 74.90%
=======================================
Files 13 13
Lines 1307 1307
=======================================
Hits 979 979
Misses 328 328 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- README.md (7 hunks)
- sleap_roots/series.py (1 hunks)
Additional comments not posted (1)
README.md (1)
130-149
: The tutorials section is a valuable addition. Enhance its visibility by adding a table of contents at the beginning of the README with a link to this section.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- README.md (7 hunks)
Additional comments not posted (4)
README.md (4)
33-34
: Consider adding a brief comment above theprimary_name
andlateral_name
parameters to explain their purpose and usage, as previously suggested.plant = sr.Series.load( "tests/data/canola_7do/919QDUH.h5", + # Specify the names of the primary and lateral roots for trait calculation primary_name="primary", lateral_name="lateral" )
49-50
: Similar to the previous comment, consider adding explanatory comments for theprimary_name
andlateral_name
parameters in batch processing examples, as previously suggested.plants = [ sr.Series.load( plant_path, + # Specify the names of the primary and lateral roots for trait calculation primary_name="primary", lateral_name="lateral", ) for plant_path in plant_paths]
62-62
: Add a comment explaining the purpose of importingget_all_pts_array
for clarity, as previously suggested.import numpy as np + # Import utility for combining primary and lateral root points from sleap_roots.points import get_all_pts_array
130-149
: The new section on using Jupyter notebooks for tutorials is clear and informative. However, consider replacing "for use on your own data" with "for use with your own data" for grammatical correctness, as previously suggested.- You can use the test data located at `tests/data` or copy the notebooks elsewhere for use on your own data! + You can use the test data located at `tests/data` or copy the notebooks elsewhere for use with your own data!
pyproject.toml
so that the notebooks folder is not automatically registered as a package in our flat layout structureMultipleDicotPipeline
MultipleDicotPipeline
example usageDicotPipeline
example usageYoungerMonocotPipeline
example usageOlderMonocotPipelline
example usageSummary by CodeRabbit
MultipleDicotPipeline.ipynb
for loading root predictions, processing with a custom pipeline, and visualizing results.group
to theSeries
class representing the group name for the series from the CSV.sleap_roots
and exclusion ofnotebooks
.