add ReplayGain support #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is there any reason to not just always apply track level ReplayGain? I prefer to reduce unnecessary options if possible |
tamland
reviewed
Dec 26, 2024
|
if track level replaygain is always applied, you run the risk of changing the dynamics of tracks within an album. so an intro track the artist intented to a be quiet would now be louder that said, doing it at a track level is good if the user is listening to a playlist of tracks from lots of places and wants to normalise them all kind of depends on your listening mode. that's why I thought the toggle would be nice there 👌 |
tamland
reviewed
Dec 28, 2024
src/player/audio.ts
Outdated
| @@ -144,12 +171,46 @@ export class AudioController { | |||
| return | |||
| } | |||
| const elapsed = Date.now() - startTime | |||
| this.audio.volume = clamp(0.0, this.volume, from + (elapsed * step)) | |||
| const baseVolume = clamp(0.0, this.volume, from + (elapsed * step)) | |||
| this.audio.volume = baseVolume * replayGainFactor | |||
| this.handle = setTimeout(run, 10) | |||
There was a problem hiding this comment.
Btw. I don't think the fade will be correct now.. It may fade in too fast since replayGainFactor isn't induced in the step size
sentriz
force-pushed
the
only-replaygain
branch
from
30ad575 to
7285dcf
Compare
sentriz
force-pushed
the
only-replaygain
branch
from
7285dcf to
30545f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a quick toggle to choose between
ReplayGain 2.0 is specfifed here https://wiki.hydrogenaud.io/index.php?title=ReplayGain_2.0_specification
Settings are only applied if a valid
replayGainobject in thesongresponse20241217_204019.mp4