By symbol match improvements #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammoippen
requested changes
Nov 6, 2024
iso4217parse/__init__.py
Outdated
Comment on lines
203
to
205
| symbol_pattern = symbol | ||
| symbol_pattern = symbol_pattern.replace("$", r"\$") # $ means endline | ||
| symbol_pattern = symbol_pattern.replace(".", r"\.") # . means anything |
There was a problem hiding this comment.
Instead of escaping special characters by hand please use the re.escape function.
There was a problem hiding this comment.
Thanks, I did not know that 👍
|
Thank you for your interest in this project. There is just this minor request i have, then we are good for merge. :D |
roxanebellot
force-pushed
the
by_symbol_match_improvements
branch
from
1c22425
to
6a1547d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
This may be out of nowhere, but playing around with your lib, and found the "heuristic" in
by_symbol_matchcould be significantly improved by using a regex to avoid finding currency symbols in words.This both improves the detection of the right currency and reduces the detection of bad currencies !
For reference, I also added a little case-insensitivness test case :)
Yesterday, I was so overhyped I created #10 that was not ready. Github won't let me re-open it because if was force-pushed☹️