Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-7054 Remove zero transactions from Transaction history #807

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

amuraveinik
Copy link
Contributor

@amuraveinik amuraveinik commented Aug 16, 2024

IOS-7054

Потестил на аккаунте пользователя, который обращался в поддержку, ссылка была в треде обсуждения
Было/Стало

Также проверил на троне
Аккаунт

Было/Стало

func loadTransactionHistory(request: TransactionHistory.Request) -> AnyPublisher<TransactionHistory.Response, Error>
func reset()
}

public extension TransactionHistoryProvider {
func shouldBeIncludedInHistory(amountType: Amount.AmountType, record: TransactionRecord) -> Bool {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Логика как в андроиде

fun shouldExcludeFromHistory(filterType: TransactionHistoryRequest.FilterType, amount: Amount): Boolean {
  return when (filterType) {
    TransactionHistoryRequest.FilterType.Coin -> return false
    is TransactionHistoryRequest.FilterType.Contract -> amount.value == null || amount.value.signum() == 0
  }
}

@amuraveinik amuraveinik marked this pull request as ready for review August 16, 2024 14:41
Andoran90
Andoran90 previously approved these changes Aug 16, 2024
@tureck1y tureck1y merged commit 4b816dc into develop Aug 16, 2024
1 check passed
@tureck1y tureck1y deleted the feature/IOS-7054_zero_transactions branch August 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants